On Tue, May 13, 2014 at 05:54:01PM +0200, Maxime Ripard wrote:
> On Tue, May 13, 2014 at 10:34:05AM -0500, Felipe Balbi wrote:
> > without that stub, drivers will fail to build
> > when CONFIG_RESET_CONTROLLER=n.
> >
> > Signed-off-by: Felipe Balbi <ba...@ti.com>
> > ---
> > include/linux/reset.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > index c0eda50..aa94420 100644
> > --- a/include/linux/reset.h
> > +++ b/include/linux/reset.h
> > @@ -75,6 +75,12 @@ static inline struct reset_control
> > *devm_reset_control_get_optional(
> > return ERR_PTR(-ENOSYS);
> > }
> >
> > +static inline struct reset_control *devm_reset_control_get(
> > + struct device *dev, const char *id)
> > +{
> > + return ERR_PTR(-ENOSYS);
> > +}
> > +
>
> reset_control_get should only be used in cases where the reset
> controller is mandatory for the driver to work, and hence, this driver
> should select or depend on CONFIG_RESET_CONTROLLER
>
> If the reset controller is optional, reset_control_get_optional should
> be preferred, that is stubed out.fair enough, depends on it is -- balbi
signature.asc
Description: Digital signature
