This helps hang troubleshooting efforts when only dmesg is available.

While here remove code duplication with MS_RDONLY case and fix a whitespace nit.

Signed-off-by: Mateusz Guzik <[email protected]>
Cc: [email protected]
Cc: Josef Bacik <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Eric Sandeen <[email protected]>
Cc: Joe Perches <[email protected]>
---
since v1:
        fix copy-pasto which found its way into the patch
        restore curly brackets in MS_RDONLY case
 fs/super.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 017e10a..4dd7356 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1291,9 +1291,7 @@ int freeze_super(struct super_block *sb)
 
        if (sb->s_flags & MS_RDONLY) {
                /* Nothing to do really... */
-               sb->s_writers.frozen = SB_FREEZE_COMPLETE;
-               up_write(&sb->s_umount);
-               return 0;
+               goto out;
        }
 
        /* From now on, no new normal writers can start */
@@ -1335,8 +1333,10 @@ int freeze_super(struct super_block *sb)
         * This is just for debugging purposes so that fs can warn if it
         * sees write activity when frozen is set to SB_FREEZE_COMPLETE.
         */
+out:
        sb->s_writers.frozen = SB_FREEZE_COMPLETE;
        up_write(&sb->s_umount);
+       pr_info("VFS:Filesystem %s frozen\n", sb->s_id);
        return 0;
 }
 EXPORT_SYMBOL(freeze_super);
@@ -1374,7 +1374,7 @@ out:
        smp_wmb();
        wake_up(&sb->s_writers.wait_unfrozen);
        deactivate_locked_super(sb);
-
+       pr_info("VFS:Filesystem %s thawed\n", sb->s_id);
        return 0;
 }
 EXPORT_SYMBOL(thaw_super);
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to