On 05/14/2014 07:28 PM, Prabhakar Lad wrote:
> Hi Hans,
>
> Thanks for the review.
>
> On Mon, May 12, 2014 at 3:20 PM, Hans Verkuil <[email protected]> wrote:
>> Hi Prabhakar,
>>
>> Thanks for the patch, but I have a few comments...
>>
>> On 05/12/2014 10:58 AM, Lad, Prabhakar wrote:
>>> Buffer ioctls:
>>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>>> fail: v4l2-test-buffers.cpp(506): q.has_expbuf()
>>
>> This is weird. I'm not sure why this happens since you seem to have
>> VB2_DMABUF set
>> and also vb2_ioctl_expbuf.
>>
>>> test VIDIOC_EXPBUF: FAIL
>>>
>>> Total: 38, Succeeded: 35, Failed: 3, Warnings: 0
>>
>> Also test with 'v4l2-compliance -s' (streaming). The '-i' option is
>> available to
>> test streaming from a specific input.
>>
> BTW the output is with -s option set.
Something is wrong. With -s you should see something like this:
Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
test VIDIOC_EXPBUF: OK (Not Supported)
test read/write: OK
test MMAP: OK
test USERPTR: OK
test DMABUF: Cannot test, specify --expbuf-device
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
