On Wed, 2014-05-14 at 16:08 -0400, David Miller wrote: > From: Joe Perches <j...@perches.com> > Date: Tue, 13 May 2014 20:30:07 -0700 > > > Missing a colon on definition use is a bit odd so > > change the macro for the 32 bit case to declare an > > __attribute__((unused)) and __deprecated variable. > > > > The __deprecated attribute will cause gcc to emit > > an error if the variable is actually used. > > > > Signed-off-by: Joe Perches <j...@perches.com> > > This is fine, applied, thanks Joe. > > Perhaps it would have been nicer to make the macros be initializers, > so that it still would look like a proper variable declaration at > the use sites: > > const __addrpair var = INET_ADDR_COOKIE(x, y, z); > > or something like that.
Maybe so, but there's no way to add an __attribute__ before the = sign for the 32 bit case like that without another #define and it would then always require initialization too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
