Arnd,
Thanks for the review. I may have more questions as I digest the comments. Here is the
immediate one.
I assume, I need to check if PCI controller's vendor ID/ device ID match with the keystone PCI controller's ID and call pcie_set_readrq() for all of the slave PCI devices and do this fixup. Is this correct understanding? If you can point me to an example code for this that will be+#ifdef CONFIG_PCI_KEYSTONE +/* + * The KeyStone PCIe controller has maximum read request size of 256 bytes. + */ +static void quirk_limit_readrequest(struct pci_dev *dev) +{ + int readrq = pcie_get_readrq(dev); + + if (readrq > 256) + pcie_set_readrq(dev, 256); +} +DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, quirk_limit_readrequest); +#endif /* CONFIG_PCI_KEYSTONE */This doesn't work: you can't just limit do this for all devices just based on PCI_KEYSTONE being enabled, you have to check if you are actually using this controller. Arnd
really helpful so that I can avoid re-inventing the wheel. Murali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
