Hi Vincent, On 8 May 2014 11:43, tip-bot for Vincent Guittot <[email protected]> wrote: > Commit-ID: 143e1e28cb40bed836b0a06567208bd7347c9672 > Gitweb: http://git.kernel.org/tip/143e1e28cb40bed836b0a06567208bd7347c9672 > Author: Vincent Guittot <[email protected]> > AuthorDate: Fri, 11 Apr 2014 11:44:37 +0200 > Committer: Ingo Molnar <[email protected]> > CommitDate: Wed, 7 May 2014 13:33:49 +0200 > > sched: Rework sched_domain topology definition > > We replace the old way to configure the scheduler topology with a new method > which enables a platform to declare additionnal level (if needed). > > We still have a default topology table definition that can be used by platform > that don't want more level than the SMT, MC, CPU and NUMA ones. This table can > be overwritten by an arch which either wants to add new level where a load > balance make sense like BOOK or powergating level or wants to change the flags > configuration of some levels. > > For each level, we need a function pointer that returns cpumask for each cpu, > a function pointer that returns the flags for the level and a name. Only flags > that describe topology, can be set by an architecture. The current topology > flags are: > > SD_SHARE_CPUPOWER > SD_SHARE_PKG_RESOURCES > SD_NUMA > SD_ASYM_PACKING > > Then, each level must be a subset on the next one. The build sequence of the > sched_domain will take care of removing useless levels like those with 1 CPU > and those with the same CPU span and no more relevant information for > load balancing than its children. > > Signed-off-by: Vincent Guittot <[email protected]> > Tested-by: Dietmar Eggemann <[email protected]> > Reviewed-by: Preeti U Murthy <[email protected]> > Reviewed-by: Dietmar Eggemann <[email protected]> > Signed-off-by: Peter Zijlstra <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Chris Metcalf <[email protected]> > Cc: Christoph Lameter <[email protected]> > Cc: David S. Miller <[email protected]> > Cc: Fenghua Yu <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Hanjun Guo <[email protected]> > Cc: Heiko Carstens <[email protected]> > Cc: Jason Low <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Martin Schwidefsky <[email protected]> > Cc: Tony Luck <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Link: > http://lkml.kernel.org/r/[email protected] > Signed-off-by: Ingo Molnar <[email protected]> > --- > arch/ia64/include/asm/topology.h | 24 ---- > arch/s390/include/asm/topology.h | 2 - > arch/tile/include/asm/topology.h | 33 ------ > include/linux/sched.h | 53 +++++++++ > include/linux/topology.h | 128 +++------------------ > kernel/sched/core.c | 233 > ++++++++++++++++++++------------------- > 6 files changed, 186 insertions(+), 287 deletions(-)
> diff --git a/include/linux/sched.h b/include/linux/sched.h > index 2a4298f..656b035 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -985,6 +1006,38 @@ void free_sched_domains(cpumask_var_t doms[], unsigned > int ndoms); > > bool cpus_share_cache(int this_cpu, int that_cpu); > > +typedef const struct cpumask *(*sched_domain_mask_f)(int cpu); > +typedef const int (*sched_domain_flags_f)(void); I just noticed, since May 9th, linux-next (ARCH=metag, gcc 4.2.4, with meta2_smp_defconfig) is showing loads of warnings due to the above line: include/linux/sched.h +1010 : warning: type qualifiers ignored on function return type Looks to me that the const serves no purpose in this context and could be removed. Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
