On Fri, May 16, 2014 at 04:09:59PM +0200, Stephane Eranian wrote: > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > index 635cd8f..0e91ba9 100644 > > --- a/tools/perf/util/sort.c > > +++ b/tools/perf/util/sort.c > > @@ -1,3 +1,4 @@ > > +#include <sys/mman.h> > > #include "sort.h" > > #include "hist.h" > > #include "comm.h" > > @@ -764,6 +765,102 @@ static int hist_entry__snoop_snprintf(struct > > hist_entry *he, char *bf, > > return repsep_snprintf(bf, size, "%-*s", width, out); > > } > > > > +#define CACHE_LINESIZE 64 > I had something similar to your patch here in my original series for > perf mem, but I never pushed it. > I think this is a useful feature to have. > However, I don't think you can hardcode the cache line size to 64. > This is generic > code. There may be architectures where the line size is different from 64. > So I think you should add an option to change the default line size or provide > an arch-specific definition.
I agree. I'll dig up a way to do that. Thanks! Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
