From: Miklos Szeredi <mik...@szeredi.hu> Date: Fri, 16 May 2014 11:09:02 +0200
> On Thu, May 15, 2014 at 6:49 PM, David Miller <da...@davemloft.net> wrote: >> From: Miklos Szeredi <mik...@szeredi.hu> >> Date: Thu, 15 May 2014 14:22:33 +0200 >> >>> On Fri, Apr 11, 2014 at 12:25 PM, Miklos Szeredi <mik...@szeredi.hu> wrote: >>>> From: Miklos Szeredi <mszer...@suse.cz> >>>> >>>> Signed-off-by: Miklos Szeredi <mszer...@suse.cz> >>>> Cc: David S. Miller <da...@davemloft.net> >>> >>> David, >>> >>> I'll be sending a batch of patches with arch support for the renameat2 >>> syscall to Linus next week. If you'd like me to send this as well, >>> could you please ACK it? >> >> For the 32-bit compat case on sparc64, you need to add a wrapper to >> sign extend the oldfd and newfd arguments. >> >> This usually occurs in arch/sparc/kernel/sys32.S, probably something >> like: >> >> SIGN2(sys32_renameat2, sys_renameat2, %o0, %o2) >> >> and then you hook up sys32_renameat2 instead of sys_renameat2 in the >> 32-bit compat syscall table in syscall_64.S > > Are you sure? None of the *at() functions (including renameat()) are in > there. Those are in error too. Any argument which is signed needs this treatment. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
