From: Rickard Strandqvist <[email protected]> Date: Sat, 17 May 2014 19:18:21 +0200
> There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <[email protected]> ... > @@ -2208,8 +2208,12 @@ static int l3dss1_cmd_global(struct PStack *st, > isdn_ctrl *ic) > { free_invoke_id(st, id); > return (-2); > } > - pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; /* > remember id */ > - pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* and > procedure */ > + > + if (pc) > + { > + pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; > /* remember id */ > + pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* > and procedure */ > + } I think rather the intention was to put these pc-> assignments in the timeout > 0 code block. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
