2014-05-19 (월), 15:12 +0200, Jiri Olsa: > On Mon, May 19, 2014 at 03:25:48PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1104,27 +1104,35 @@ static int hist_browser__fprintf_entry(struct > > hist_browser *browser, > > struct hist_entry *he, FILE *fp) > > { > > char s[8192]; > > - double percent; > > int printed = 0; > > char folded_sign = ' '; > > + struct perf_hpp hpp = { > > + .buf = s, > > + .size = sizeof(s), > > + }; > > + struct perf_hpp_fmt *fmt; > > + bool first = true; > > + int ret; > > > > if (symbol_conf.use_callchain) > > folded_sign = hist_entry__folded(he); > > > > - hist_entry__sort_snprintf(he, s, sizeof(s), browser->hists); > > - percent = (he->stat.period * 100.0) / > > browser->hists->stats.total_period; > > - > > if (symbol_conf.use_callchain) > > printed += fprintf(fp, "%c ", folded_sign); > > > > - printed += fprintf(fp, " %5.2f%%", percent); > > - > > - if (symbol_conf.show_nr_samples) > > - printed += fprintf(fp, " %11u", he->stat.nr_events); > > + perf_hpp__for_each_format(fmt) { > > + if (perf_hpp__should_skip(fmt)) > > + continue; > > this one is defined in later patch, so it breaks build in this one
Argh, right. This one came from a later fixup with interactive rebase and missed test.. I'll fix and resend, sorry about that. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/