On Tue, 2014-05-20 at 19:33 +0200, Borislav Petkov wrote: > On Tue, May 20, 2014 at 10:11:25AM +0800, Chen Yucong wrote: > > mces_seen is a Per-CPU variable which should only be accessed by > > Per-CPU as possible. So the clear operation of mces_seen should also > > be lcoal to Per-CPU rather than monarch CPU. > > > > Meanwhile, there is also a potential risk that mces_seen will not > > be be cleared if a timeout occors in mce_end for monarch CPU. As a > > reuslt, the stale value of mces_seen will reappear on the next mce. > > I don't know how many times I have to tell you this already: if we reach > the timeout, we have a much bigger friggin' problem! > > What you could do instead is make the machine panic in the tolerant==1, > i.e., the default case, in mce_timed_out(). > > Basically, in the case any core is stuck and we reach a timeout, we want > to panic the whole box immediately. There's a very little chance we can > recover so panic is the only sane thing left to do. > > Ok?
Do you have any strong reasons to claim that a timeout is raised by any core which is stuck? In other word, what is the probability that an timeout is caused by stuck cores? thx! cyc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
