> -----Original Message-----
> From: iommu-boun...@lists.linux-foundation.org [mailto:iommu-
> boun...@lists.linux-foundation.org] On Behalf Of Rickard Strandqvist
> Sent: Saturday, May 17, 2014 10:47 PM
> To: Joerg Roedel; Grant Likely
> Cc: devicet...@vger.kernel.org; io...@lists.linux-foundation.org; Rob Herring;
> linux-kernel@vger.kernel.org; Rickard Strandqvist
> Subject: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer dereference
>
> There is otherwise a risk of a possible null pointer dereference.
You are right.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Reviewed-by: Bharat Bhushan <bharat.bhus...@freescale.com>
Thanks
-Bharat
> ---
> drivers/iommu/fsl_pamu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index
> cba0498..b99dd88 100644
> --- a/drivers/iommu/fsl_pamu.c
> +++ b/drivers/iommu/fsl_pamu.c
> @@ -592,8 +592,7 @@ found_cpu_node:
> /* advance to next node in cache hierarchy */
> node = of_find_node_by_phandle(*prop);
> if (!node) {
> - pr_debug("Invalid node for cache hierarchy %s\n",
> - node->full_name);
> + pr_debug("Invalid node for cache hierarchy\n");
> return ~(u32)0;
> }
> }
> --
> 1.7.10.4
>
> _______________________________________________
> iommu mailing list
> io...@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
