On 05/21/2014 01:57 PM, Kui Zhang wrote: > Hello, > > I get following error when rmmod thermal. > > rmmod thermal > Killed
Thanks for the report. Here is a fix patch that should solve this problem. From: Aaron Lu <[email protected]> Date: Wed, 21 May 2014 16:00:42 +0800 Subject: [PATCH] ACPI / thermal: fix workqueue destroy order When the thermal module is to be removed, we should destroy the wq acpi_thermal_pm_queue after the ACPI driver's remove callback is executed as we will need to flush the workqueue there, or a NULL pointer access will be hit. Reported-by: Kui Zhang <[email protected]> Reference: http://www.spinics.net/lists/kernel/msg1747251.html Cc: All applicable <[email protected]> Signed-off-by: Aaron Lu <[email protected]> --- drivers/acpi/thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index c1e31a41f949..25bbc55dca89 100644 --- a/drivers/acpi/thermal.c +++ b/drivers/acpi/thermal.c @@ -1278,8 +1278,8 @@ static int __init acpi_thermal_init(void) static void __exit acpi_thermal_exit(void) { - destroy_workqueue(acpi_thermal_pm_queue); acpi_bus_unregister_driver(&acpi_thermal_driver); + destroy_workqueue(acpi_thermal_pm_queue); return; } -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
