On Wed, May 21, 2014 at 03:11:42PM -0700, Andrew Morton wrote: > On Wed, 21 May 2014 13:09:16 +0100 Mel Gorman <mgor...@suse.de> wrote: > > > > From: Andrew Morton <a...@linux-foundation.org> > > > Subject: mm/shmem.c: don't run init_page_accessed() against an > > > uninitialised pointer > > > > > > If shmem_getpage() returned an error then it didn't necessarily initialise > > > *pagep. So shmem_write_begin() shouldn't be playing with *pagep in this > > > situation. > > > > > > Fixes an oops when "mm: non-atomically mark page accessed during page > > > cache allocation where possible" (quite reasonably) left *pagep > > > uninitialized. > > > > > > Reported-by: Prabhakar Lad <prabhakar.cse...@gmail.com> > > > Cc: Johannes Weiner <han...@cmpxchg.org> > > > Cc: Vlastimil Babka <vba...@suse.cz> > > > Cc: Jan Kara <j...@suse.cz> > > > Cc: Michal Hocko <mho...@suse.cz> > > > Cc: Hugh Dickins <hu...@google.com> > > > Cc: Peter Zijlstra <pet...@infradead.org> > > > Cc: Dave Hansen <dave.han...@intel.com> > > > Cc: Mel Gorman <mgor...@suse.de> > > > Signed-off-by: Andrew Morton <a...@linux-foundation.org> > > > > Acked-by: Mel Gorman <mgor...@suse.de> > > What to do with > http://ozlabs.org/~akpm/mmots/broken-out/mm-non-atomically-mark-page-accessed-during-page-cache-allocation-where-possible-fix.patch? > > We shouldn't need it any more. otoh it's pretty harmless. otooh it > will hide bugs such as this one. >
Drop it. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
