On Thu, May 22, 2014 at 12:59:03PM +0800, Zhu, Lejun wrote: > +static int crystalcove_gpio_probe(struct platform_device *pdev) > +{ > + int irq = platform_get_irq(pdev, 0); > + struct crystalcove_gpio *cg; > + int retval; > + struct device *dev = pdev->dev.parent; > + > + cg = devm_kzalloc(&pdev->dev, sizeof(*cg), GFP_KERNEL); > + if (!cg) {
A minor comment here: return -ENOMEM; > + retval = -ENOMEM; > + goto out; > + } Other than that this looks good to me, Reviewed-by: Mika Westerberg <mika.westerb...@linux.intel.com> I suppose this is dependent on the MFD driver right? If so, this should probably be merged along with that patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/