On Thu, May 22, 2014 at 5:37 AM, Paul Bolle <pebo...@tiscali.nl> wrote: > Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig > symbol has never been added to the tree. Remove these checks, as they > always evaluate to false. > > Signed-off-by: Paul Bolle <pebo...@tiscali.nl>
Thanks for pointing this out. ASV was supposed to be merged, but it appears it failed or never attempted. I will merge with the next batch (this week). Cheers, MyungJoo. > --- > 0) Untested. > > 1) I do not really care much for this patch. Two years is not very long > for dead code to remain in the tree. There is, however, a trivial issue > that makes this patch stand out from the other patches in my current > sweep of the tree for Kconfig related problems. > > See, here the use of an unknown Kconfig macro hides an obvious typo: it > should either be "exynos_result_of_asv" or "exynos4_result_of_asv", but > not both. Ie, this almost certainly wouldn't have compiled even if the > Kconfig symbol EXYNOS_ASV would have been part of the tree. > > 2) So this makes me wonder whether there are any guidelines for using > Kconfig macros before the related Kconfig symbols are merged? > > drivers/devfreq/Kconfig | 3 +-- > drivers/devfreq/exynos/exynos4_bus.c | 13 ------------- > 2 files changed, 1 insertion(+), 15 deletions(-)
