On Fri, May 23, 2014 at 6:41 PM, Stephen Boyd <[email protected]> wrote: > Failure to terminate an of_device_id table can lead to confusing > failures depending on where the compiler places the array. Add a > check to make sure these tables are terminated. Thanks to Mitchel > Humpherys for coming up with the initial pattern.
I've definitely debugged one of those problems. Do you have any actual fixes or there are no errors in the kernel? Rob > > Cc: Mitchel Humpherys <[email protected]> > Cc: Julia Lawall <[email protected]> > Cc: Gilles Muller <[email protected]> > Cc: Nicolas Palix <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: [email protected] > Signed-off-by: Stephen Boyd <[email protected]> > --- > scripts/coccinelle/misc/of_table.cocci | 81 > ++++++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 scripts/coccinelle/misc/of_table.cocci > > diff --git a/scripts/coccinelle/misc/of_table.cocci > b/scripts/coccinelle/misc/of_table.cocci > new file mode 100644 > index 000000000000..da8bfa69fa3e > --- /dev/null > +++ b/scripts/coccinelle/misc/of_table.cocci > @@ -0,0 +1,81 @@ > +/// Make sure of_device_id tables are NULL terminated > +// > +// Keywords: of_table > +// Confidence: Medium > +// Options: --include-headers > + > +virtual patch > +virtual context > +virtual org > +virtual report > + > +@bad_of_table exists@ > +identifier var, arr; > +expression E; > +@@ > +... struct of_device_id arr[] = { > + ..., > + { > + ..., > + .var = E, > + ... > + } > +}; > + > +@depends on bad_of_table && context@ > +identifier var, arr; > +expression E; > +@@ > + ... struct of_device_id arr[] = { > + ..., > + { > + ..., > +* .var = E, > + ... > + } > +}; > + > +@depends on bad_of_table && patch@ > +identifier var, arr; > +expression E; > +@@ > +... struct of_device_id arr[] = { > + ..., > + { > + ..., > + .var = E, > + ... > +- } > ++ }, > ++ { } > +}; > + > +@r depends on bad_of_table exists@ > +position p1; > +identifier var, arr; > +expression E; > +@@ > +... struct of_device_id arr[] = { > + ..., > + { > + ..., > + .var = E, > + ... > + } > + @p1 > +}; > + > +@script:python depends on org@ > +p1 << r.p1; > +arr << r.arr; > +@@ > + > +cocci.print_main(arr,p1) > + > +@script:python depends on report@ > +p1 << r.p1; > +arr << r.arr; > +@@ > + > +msg = "%s is not NULL terminated at line %s" % (arr, p1[0].line) > +coccilib.report.print_report(p1[0],msg) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
