On Tue, May 27, 2014 at 08:01:55AM +0200, Alexander Holler wrote: > Am 27.05.2014 05:12, schrieb Alexander Shiyan: > >Should we add "driver.owner = THIS_MODULE" field for struct platform_driver > >in this case? > > Yes. I assumed all drivers/modules already had an owner. I will > check them all and will send a v2 for those which don't have one. I > wonder what this field is used for if it works without. ;)
Looks like the mtd->owner essentially filters down to a try_module_get() (called in the get_mtd_device() API) which ensures that MTD users (e.g., mtdblock, UBI, etc.) hold a refcount on the driver module. If the owner is not set properly by a driver, then try_module_get() just does a silent no-op, so the user is none the wiser... until they try to rmmod their MTD driver while it's being used by UBI/UBIFS! Regards, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
