Hi Ming, On Thu, May 29, 2014 at 12:59:19AM +0800, Ming Lei wrote: > > Actually, the correct thing may be like what did in the > attached patch, as Maurizio discussed with me[1]. > > Very interestingly, I have reproduced the problem one time > with ext4/271 ext4/301 ext4/305, but won't with the attached > patch after running it for 3 rounds. > > [tom@localhost xfstests]$ sudo ./check ext4/271 ext4/301 ext4/305 > FSTYP -- ext4 > PLATFORM -- Linux/x86_64 localhost 3.15.0-rc7-next-20140527+ > MKFS_OPTIONS -- /dev/vdc > MOUNT_OPTIONS -- -o acl,user_xattr /dev/vdc /mnt/scratch > > ext4/271 1s ... 1s > ext4/301 31s ... 32s > ext4/305 181s ... 180s > Ran: ext4/271 ext4/301 ext4/305 > Passed all 3 tests > > Jet, could you test the attached patch? > > [1], https://lkml.org/lkml/2014/5/27/327
There is a little mistake in your patch, you removed bio->bi_iter.bi_size += len; after the "done" label, but be careful that at line 747 there is a "goto done"... bi_size should be incremented before jumping there. Thanks, Maurizio Lombardi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/