On 05/27/2014 06:50 AM, Viresh Kumar wrote: > Drivers expecting CPU's OPPs from device tree initialize OPP table themselves > by > calling of_init_opp_table() and there is nothing driver specific in that. They > all do it in the same redundant way. > > It would be better if we can get rid of redundancy by initializing CPU OPPs > from > CPU core code for all CPUs (that have a "operating-points" property defined in > their node). > > This patch calls of_init_opp_table() right after CPU device is registered in > register_cpu(). of_init_opp_table() also has a dummy implementation which > simply > returns -ENOSYS when CONFIG_OPP or CONFIG_OF isn't supported by some platform. > > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Amit Daniel Kachhap <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Sudeep Holla <[email protected]> > Signed-off-by: Viresh Kumar <[email protected]> > --- > drivers/base/cpu.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 006b1bc..790183f 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -16,6 +16,7 @@ > #include <linux/acpi.h> > #include <linux/of.h> > #include <linux/cpufeature.h> > +#include <linux/pm_opp.h> > > #include "base.h" > > @@ -349,10 +350,12 @@ int register_cpu(struct cpu *cpu, int num) > if (cpu->hotpluggable) > cpu->dev.groups = hotplugable_cpu_attr_groups; > error = device_register(&cpu->dev); > - if (!error) > - per_cpu(cpu_sys_devices, num) = &cpu->dev; > - if (!error) > - register_cpu_under_node(num, cpu_to_node(num)); > + if (error) > + return error; > + > + per_cpu(cpu_sys_devices, num) = &cpu->dev; > + register_cpu_under_node(num, cpu_to_node(num));
The change so far is a improvement in error handling -> which, personally I find nice, but not necessarily related to the $subject or covered in commit message. I suggest splitting that specific change out as a patch of it's own. > + of_init_opp_table(&cpu->dev); tricky... :) I finally did catchup on previous discussions https://patchwork.kernel.org/patch/4199601/ https://patchwork.kernel.org/patch/4199741/ https://patchwork.kernel.org/patch/4215901/ https://patchwork.kernel.org/patch/4220431/ So, will let Rafael comment better here. > > return error; > } > -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
