Ming Lei <ming....@canonical.com> writes:
> Firstly, it isn't necessary to hold lock of vblk->vq_lock
> when notifying hypervisor about queued I/O.
>
> Secondly, virtqueue_notify() will cause world switch and
> it may take long time on some hypervisors(such as, qemu-arm),
> so it isn't good to hold the lock and block other vCPUs.
>
> On arm64 quad core VM(qemu-kvm), the patch can increase I/O
> performance a lot with VIRTIO_RING_F_EVENT_IDX enabled:
>       - without the patch: 14K IOPS
>       - with the patch: 34K IOPS
>
> fio script:
>       [global]
>       direct=1
>       bsrange=4k-4k
>       timeout=10
>       numjobs=4
>       ioengine=libaio
>       iodepth=64
>
>       filename=/dev/vdc
>       group_reporting=1
>
>       [f1]
>       rw=randread
>
> Cc: Rusty Russell <ru...@rustcorp.com.au>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: virtualizat...@lists.linux-foundation.org
> Signed-off-by: Ming Lei <ming....@canonical.com>

Acked-by: Rusty Russell <ru...@rustcorp.com.au>

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to