On 05/30/2014 06:48 PM, Keith Busch wrote: > On Thu, 29 May 2014, Matias Bjørling wrote: >> This converts the current NVMe driver to utilize the blk-mq layer. > > I'm pretty darn sure this new nvme_remove can cause a process > with an open reference to use queues after they're freed in the > nvme_submit_sync_command path, maybe even the admin tags too. >
You're right. I'll put a fix in v5. >> @@ -2802,7 +2574,7 @@ static void nvme_remove(struct pci_dev *pdev) >> nvme_dev_remove(dev); >> nvme_dev_shutdown(dev); >> nvme_free_queues(dev, 0); >> - rcu_barrier(); >> + nvme_free_admin_tags(dev); >> nvme_release_instance(dev); >> nvme_release_prp_pools(dev); >> kref_put(&dev->kref, nvme_free_dev); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
