Hi, On 02.06.2014 14:35, Bartlomiej Zolnierkiewicz wrote: > From: Kyungmin Park <[email protected]> > > To support multi-platform, it needs to know it's running under secure > OS or not. Sometimes it needs to access physical address by SMC calls. > > e.g., > if (firmware_run()) { > addr = physical address; > } else { > addr = virtual address; > } > > call_firmware_ops(read_address, addr, &value);
Hmm, I don't understand the code above. It first asks whether the firmware is available and then calls a firmware operation anyway (assuming that firmware is available regardless of the check above)... I don't like the idea of this function, because we have designed the firmware API to not require this kind of checks. Instead, you just call whatever firmware operation you need and if it returns -ENOSYS you need to fallback to legacy (firmware-less) way of doing it. Could you provide your use case for which this doesn't work? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
