On Friday 04 March 2005 00:56, Adrian Bunk wrote: > On Tue, Mar 01, 2005 at 09:15:27PM +0800, Antonino A. Daplas wrote: > > On Tuesday 01 March 2005 10:41, Adrian Bunk wrote: > > > Hi, > > > > > > while looking how to fix modular FB_SAVAGE_* (both FB_SAVAGE_I2C=m and > > > FB_SAVAGE_ACCEL=m are currently broken) I asked myself: > > > > BTW, what's the problem with the above? > > #if defined(CONFIG_FB_SAVAGE_ACCEL) > > doesn't work with FB_SAVAGE_ACCEL=m, and > > #if defined(CONFIG_FB_SAVAGE_ACCEL) || > defined(CONFIG_FB_SAVAGE_ACCEL_MODULE) > > would break with FB_SAVAGE=y and FB_SAVAGE_ACCEL=m. >
I see. > > Is there any reason for these being three modules? > It seems the best solution would be to make this one module composed of > up to three object files? Yes. Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
