On Wed, 4 Jun 2014, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Jason Cooper <ja...@lakedaemon.net>
> ---
> drivers/irqchip/irq-nvic.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
> index 70bdf6e..c935c61 100644
> --- a/drivers/irqchip/irq-nvic.c
> +++ b/drivers/irqchip/irq-nvic.c
> @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs
> *regs)
> handle_IRQ(irq, regs);
> }
>
> -static void nvic_eoi(struct irq_data *d)
> -{
> - /*
> - * This is a no-op as end of interrupt is signaled by the exception
> - * return sequence.
> - */
You shred that information. Please move the comment above the
irq_gc_noop assignment.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
