Hi Greg, Thanks for reviewing.
On Wed, Jun 4, 2014 at 11:21 PM, Greg KH <[email protected]> wrote: > On Wed, Jun 04, 2014 at 01:41:46PM +0530, [email protected] wrote: >> From: Ritesh Harjani <[email protected]> >> >> This patch moves out *mapping pointer of dma_iommu_mapping >> from arch/arm/include/asm/device.h to include/liunux/device.h > > Why? Who else can use this becides arm devices? Currently only arm and arm64 are the archs at this very moment but later other archs can make use of this, as its an arch independent code. (Similar to as some arch make use of iommu_area_alloc in iommu-helper.c) > >> >> Also, it moves out complete structre definition of dma_iommu_mapping >> to include/linux/iommu-helper.h >> >> This is done since arm iommu's dma-mapping arch independent code, >> needs to be moved out to lib/iommu-helper.c, this means >> dma_iommu_mapping will be arch independent and later other archs >> can make use of it. > > Will that really happen? Do you have patches that do that? I'd prefer > to not do stuff like this until you have a patch series that needs it, > otherwise this is just unneeded churn. Yes, foll link has the patch series, (under review) http://www.spinics.net/lists/arm-kernel/msg336896.html > >> --- a/include/linux/device.h >> +++ b/include/linux/device.h >> @@ -705,6 +705,10 @@ struct device { >> /* arch specific additions */ >> struct dev_archdata archdata; >> >> +#ifdef CONFIG_DMA_USE_IOMMU_HELPER_MAPPING >> + struct dma_iommu_mapping *mapping; >> +#endif >> + >> struct device_node *of_node; /* associated device tree node */ >> struct acpi_dev_node acpi_node; /* associated ACPI device node */ >> > > Are you sure this will not break the build on systems that enable that > option, yet do not include iommu-helper.h? They need to include iommu-helper.h wherever they are using this structure members. Until then no this should not break the build I think for the case you mentioned. That's how it was done in arch/arm/include/asm/device.h Do I need to do this in diff way ? > > thanks, > > greg k-h Thanks Ritesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
