On Thu, Jun 05, 2014 at 11:23:04AM +0200, Frank Haverkamp wrote: > Hi Greg, > > Am Mittwoch, den 04.06.2014, 08:54 -0700 schrieb Greg KH: > > On Wed, Jun 04, 2014 at 10:57:53AM -0300, Kleber Sacilotto de Souza wrote: > > > Increase genwqe driver version number. > > > > > > Signed-off-by: Kleber Sacilotto de Souza <kleb...@linux.vnet.ibm.com> > > > --- > > > drivers/misc/genwqe/genwqe_driver.h | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/misc/genwqe/genwqe_driver.h > > > b/drivers/misc/genwqe/genwqe_driver.h > > > index cd52631..a506e9a 100644 > > > --- a/drivers/misc/genwqe/genwqe_driver.h > > > +++ b/drivers/misc/genwqe/genwqe_driver.h > > > @@ -36,7 +36,7 @@ > > > #include <asm/byteorder.h> > > > #include <linux/genwqe/genwqe_card.h> > > > > > > -#define DRV_VERS_STRING "2.0.15" > > > +#define DRV_VERS_STRING "2.0.21" > > > > Why is this even needed? Can't you go off of the kernel version number > > now? Who needs / wants this number? > > I am aware that if just considering the mainline kernels, we could use > the kernel version itself for the purpose of identifying which code we > are running.
Which is what you are patching here :) > But in our lab we are running multiple back-ported versions of this > driver on different Linux distributions using different kernel versions. Then deal with that in the backported code, the upstream kernel doesn't care about this. > Our user-space software needs to know if the driver has or has not > bug-fixes or features. For this purpose, we are using this extra number. Why would you rely on a version number for this, shouldn't you be able to tell with your api what features are present? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
