From: Ken Helias <[email protected]> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name.
Signed-off-by: Ken Helias <[email protected]> Cc: [email protected] --- drivers/s390/block/dasd_3990_erp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dasd_3990_erp.c b/drivers/s390/block/dasd_3990_erp.c index d261347..2189e45 100644 --- a/drivers/s390/block/dasd_3990_erp.c +++ b/drivers/s390/block/dasd_3990_erp.c @@ -2761,7 +2761,7 @@ dasd_3990_erp_action(struct dasd_ccw_req * cqr) if (list_empty(&erp->blocklist)) { cqr->status = DASD_CQR_IN_ERP; /* add erp request before the cqr */ - list_add_tail(&erp->blocklist, &cqr->blocklist); + list_add_before(&erp->blocklist, &cqr->blocklist); } -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
