From: Ken Helias <kenhel...@firemail.de> The argument names of the hlist_add_after are poorly chosen because they look the same as the ones from hlist_add_before but have to be used completely different. This easily confuses the reader. The creator of the hlist_add_after_rcu function has made a lot better choice.
Signed-off-by: Ken Helias <kenhel...@firemail.de> --- v2: Splitted into two patches The patches to add list_add_before/behind were removed because it seems that there is a consensus that list_add is understood by everyone automatically as list_add_behind and list_add_tail is understood by everyone as list_add_before.... even when the names suggest otherwise. include/linux/list.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/list.h b/include/linux/list.h index ef95941..624ec7f 100644 --- a/include/linux/list.h +++ b/include/linux/list.h @@ -654,15 +654,15 @@ static inline void hlist_add_before(struct hlist_node *n, *(n->pprev) = n; } -static inline void hlist_add_after(struct hlist_node *n, - struct hlist_node *next) +static inline void hlist_add_after(struct hlist_node *prev, + struct hlist_node *n) { - next->next = n->next; - n->next = next; - next->pprev = &n->next; + n->next = prev->next; + prev->next = n; + n->pprev = &prev->next; - if(next->next) - next->next->pprev = &next->next; + if (n->next) + n->next->pprev = &n->next; } /* after that we'll appear to be on some hlist and hlist_del will work */ -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/