Thanks Peter for reviewing, and sorry for not think it thoroughly before submitting. Is that ok that when amd_uncore_cpu_up_prepare is called from amd_uncore_cpu_notifier I return notifier_from_errno(-ENOMEM), and when amd_uncore_cpu_up_prepare is called from amd_uncore_init I immediately return -ENODEV?
On Tue, Jun 10, 2014 at 4:22 PM, Peter Zijlstra <pet...@infradead.org> wrote: > On Tue, Jun 10, 2014 at 03:37:38PM +0800, Zhouyi Zhou wrote: > > Less typing more thinking, this is wrong. You should fail when the > allocation fails. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/