On Wed, 11 Jun 2014 18:44:08 -0000 Thomas Gleixner <[email protected]> wrote: > +/* > + * Futex variant with full deadlock detection. > + */ > +int __rt_mutex_timed_lock(struct rt_mutex *lock, > + struct hrtimer_sleeper *timeout)
I hate underscores. Although it's commented, it's still rather awkward. What about calling it rt_mutex_timed_futex_lock() or something else with futex in its name? Rest looks good. Reviewed-by: Steven Rostedt <[email protected]> -- Steve > +{ > + might_sleep(); > + > + return rt_mutex_timed_fastlock(lock, TASK_INTERRUPTIBLE, timeout, 1, > + rt_mutex_slowlock); > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
