> This patch fixes two problems: -
>
> 1) The device tree isn't currently providing sti-ethclk which is
> required by the dwmac glue code to correctly configure the ethernet
> PHY clock speed.
>
> This means depending on what the bootloader/jtag has
> configured this clock to, and what switch/hub the board is plugged
> into you most likely will NOT successfully negotiate a ethernet link.
>
> 2) The stmmaceth clock was associated with the wrong clock. It was
> referencing the PHY clock rather than the interconnect clock which
> clocks the IP.
>
> This patch also brings us closer to not having to boot the upstream
> kernel with the clk_ignore_unused parameter.
>
> Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> ---
> arch/arm/boot/dts/stih415.dtsi | 8 ++++----
> arch/arm/boot/dts/stih416.dtsi | 8 ++++----
> include/dt-bindings/clock/stih415-clks.h | 1 +
> include/dt-bindings/clock/stih416-clks.h | 1 +
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih415.dtsi b/arch/arm/boot/dts/stih415.dtsi
> index c81dce4..768bf27 100644
> --- a/arch/arm/boot/dts/stih415.dtsi
> +++ b/arch/arm/boot/dts/stih415.dtsi
[...]
> ethernet1: dwmac@fef08000 {
> @@ -189,11 +189,11 @@
> st,syscon = <&syscfg_sbc>;
>
> resets = <&softreset
> STIH415_ETH1_SOFTRESET>;
> - reset-names = "stmmaceth";
> + reset-names = "stmmaceth", "sti-ethclk";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_mii1>;
> clock-names = "stmmaceth";
> - clocks = <&clk_s_a0_ls CLK_ETH1_PHY>;
> + clocks = <&clk_s_a0_ls CLK_ICN_REG>,
> <&clk_s_a0_ls CLK_ETH1_PHY>;
This looks wrong to me. You appear to have changed the reset-names
instead of the clock-names here.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
