Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog

[Nishanth Menon]

On 06/18/2014 04:51 PM, Felipe Balbi wrote:
Hi,
On Wed, Jun 18, 2014 at 04:43:28PM -0500, Nishanth Menon wrote:
On 06/18/2014 02:25 PM, Felipe Balbi wrote:
Hi,

On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote:
$subject - ARM: dts:

On 06/18/2014 10:43 AM, Felipe Balbi wrote:
by providing phandles to rtc and wdt nodes, we can
let boards enable rtc and wdt as necessary.

Signed-off-by: Felipe Balbi <ba...@ti.com>
---
  arch/arm/boot/dts/am4372.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 49fa596..e3830d4 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -270,7 +270,7 @@
                        ti,hwmods = "counter_32k";
                };

-               rtc@44e3e000 {
+               rtc: rtc@44e3e000 {
                        compatible = "ti,am4372-rtc","ti,da830-rtc";
                        reg = <0x44e3e000 0x1000>;
                        interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH
@@ -279,7 +279,7 @@
                        status = "disabled";
                };

-               wdt@44e35000 {
+               wdt: wdt@44e35000 {
                        compatible = "ti,am4372-wdt","ti,omap3-wdt";
                        reg = <0x44e35000 0x1000>;
                        interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;

we might want to fix up any other similar nodes in dtsi as well, no?

examples:
cpu@0

and why would you want boards to mess with the cpu node ?

cpu-supply = <&regulator>;

for cpufreq.

good point, but does thqt even work with AM437x devices in mainline?

it will once we are done adding a node. context here being - if you are 
fixing phandles, please fix them all up.. that is a little nice to do.

I wont argue more on this. I will leave it to maintainers.

--
Regards,
Nishanth Menon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/