I was just porting over an ethernet driver [0] to use request_firmware_nowait() since firmware loading seems can take over a minute on one device, while at it I noticed no other ethernet drivers yet use this API so figure this may be a trend coming if devices are getting as complex as cxgb4. The cxgb4 driver happens to even use the firmware API 3 times!
Obviously I considered writing SmPL for this, but one thing which seemed hard was that for after the request_firmware_nowait() we tend to tuck away into another new call the rest of the code that was in place in the original function after the old request_firmware() call. Is there a way to dump all that code into the new routine? I think the hardest thing would be to also move the right set of variables over. In the third patch in this series for example [1] there was a state variable that I moved from beign static over to the ethernet private data structure. Its hard for me to think of how I can hint to Coccinelle enough information about what stuff it needs to move around. I think one hint would be: "Hey all that code that is static and is used *before* and *after* request_firmware() stuff it into the private data structure" We'd have to infer the private data structure but that's easy and I already know that's possible. Is this possible? The only other challenge I thought might be tough would be to come up with are rasonable call for the completion call, but I guess we can use the original routine name where request_firmware() was being used and postfix _completion or something. netdev: how worthy is this effort? [0] https://lkml.org/lkml/2014/6/20/688 [1] https://lkml.org/lkml/2014/6/20/691 Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
