Commit-ID:  4b92b4f754939e4ac6bb53355abbe48a5054b573
Gitweb:     http://git.kernel.org/tip/4b92b4f754939e4ac6bb53355abbe48a5054b573
Author:     Jiang Liu <jiang....@linux.intel.com>
AuthorDate: Mon, 9 Jun 2014 16:19:49 +0800
Committer:  Thomas Gleixner <t...@linutronix.de>
CommitDate: Sat, 21 Jun 2014 23:05:42 +0200

x86, irq: Simplify arch_early_irq_init()

Simplify function arch_early_irq_init() and kill static array irq_cfgx[].

Signed-off-by: Jiang Liu <jiang....@linux.intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
Cc: Tony Luck <tony.l...@intel.com>
Cc: Joerg Roedel <j...@8bytes.org>
Cc: Paul Gortmaker <paul.gortma...@windriver.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
Cc: Grant Likely <grant.lik...@linaro.org>
Cc: Rafael J. Wysocki <r...@rjwysocki.net>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: Randy Dunlap <rdun...@infradead.org>
Cc: Yinghai Lu <ying...@kernel.org>
Link: 
http://lkml.kernel.org/r/1402302011-23642-21-git-send-email-jiang....@linux.intel.com
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
---
 arch/x86/kernel/apic/io_apic.c | 33 +++++++++++----------------------
 1 file changed, 11 insertions(+), 22 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 4208ea9..e25e7e3 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -183,6 +183,7 @@ early_param("noapic", parse_noapic);
 
 static int io_apic_setup_irq_pin(unsigned int irq, int node,
                                 struct io_apic_irq_attr *attr);
+static struct irq_cfg *alloc_irq_and_cfg_at(unsigned int at, int node);
 
 /* Will be called in mpparse/acpi/sfi codes for saving IRQ info */
 void mp_save_irq(struct mpc_intsrc *m)
@@ -214,14 +215,10 @@ static struct irq_pin_list *alloc_irq_pin_list(int node)
        return kzalloc_node(sizeof(struct irq_pin_list), GFP_KERNEL, node);
 }
 
-
-/* irq_cfg is indexed by the sum of all RTEs in all I/O APICs. */
-static struct irq_cfg irq_cfgx[NR_IRQS_LEGACY];
-
 int __init arch_early_irq_init(void)
 {
        struct irq_cfg *cfg;
-       int count, node, i;
+       int i, node = cpu_to_node(0);
 
        if (!nr_legacy_irqs())
                io_apic_irqs = ~0UL;
@@ -234,22 +231,14 @@ int __init arch_early_irq_init(void)
                        pr_err("IOAPIC %d: suspend/resume impossible!\n", i);
        }
 
-       cfg = irq_cfgx;
-       count = ARRAY_SIZE(irq_cfgx);
-       node = cpu_to_node(0);
-
-       for (i = 0; i < count; i++) {
-               irq_set_chip_data(i, &cfg[i]);
-               zalloc_cpumask_var_node(&cfg[i].domain, GFP_KERNEL, node);
-               zalloc_cpumask_var_node(&cfg[i].old_domain, GFP_KERNEL, node);
-               /*
-                * For legacy IRQ's, start with assigning irq0 to irq15 to
-                * IRQ0_VECTOR to IRQ15_VECTOR for all cpu's.
-                */
-               if (i < nr_legacy_irqs()) {
-                       cfg[i].vector = IRQ0_VECTOR + i;
-                       cpumask_setall(cfg[i].domain);
-               }
+       /*
+        * For legacy IRQ's, start with assigning irq0 to irq15 to
+        * IRQ0_VECTOR to IRQ15_VECTOR for all cpu's.
+        */
+       for (i = 0; i < nr_legacy_irqs(); i++) {
+               cfg = alloc_irq_and_cfg_at(i, node);
+               cfg->vector = IRQ0_VECTOR + i;
+               cpumask_setall(cfg->domain);
        }
 
        return 0;
@@ -3377,7 +3366,7 @@ int __init arch_probe_nr_irqs(void)
        if (nr < nr_irqs)
                nr_irqs = nr;
 
-       return nr_legacy_irqs();
+       return 0;
 }
 
 int io_apic_set_pci_routing(struct device *dev, int irq,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to