On Mon, Mar 07, 2005 at 09:35:49AM +0100, Domen Puncer wrote:
> > > - for (;;) {
> > > - interruptible_sleep_on(&cdev->recvwait);
> > > - if ((skb = skb_dequeue(&cdev->recvqueue)) != 0)
> > > - break;
> > > - if (signal_pending(current))
> > > - break;
> > > - }
> > > + wait_event_interruptible(cdev->recvwait,
> > > + ((skb = skb_dequeue(&cdev->recvqueue)) == 0));
> > > if (skb == 0)
> > > return -ERESTARTNOHAND;
> > > }
> >
> > hmm, OK. Putting an expression with side-effect such as this into a macro
> > which evaluates the expression multiple times is a bit of a worry, but it
> > appears that everything will work OK.
> >
> > That being said, I'd prefer that this come in via the ISDN team, after
> > having been tested please.
>
> I believe last update from ISDN team was 13 months ago. :-(
You are wrong. Last update was few weeks ago (not on the core).
> And I concur, testing would be great.
Will do that next week.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
