On Monday 16 June 2014 19:55:04, Oliver Hartkopp wrote: > Hello Tyler, > > On 16.06.2014 04:23, Tyler Hall wrote: > > Use schedule_work() to avoid potentially taking the spinlock in > > interrupt context. > > > (..) > > > > > To deal with these issues, don't grab the lock in the wakeup function by > > deferring the writeout to a workqueue. Also hold the lock during close > > when de-assigning the tty pointer to safely disarm the worker and > > timers. > > > > This bug is easily reproducible on the first transmit when slip is > > used with the standard 8250 serial driver. > > > > looks reasonable. Thanks for your patch! > Indeed I can't remember ever using the slcan driver with a real serial > controller hardware with irq line but only via serial-to-USB adapters :-) > Due to the recent fixes from Andre and Alexander these two drivers got in > motion again ... > > @Andre/Alexander: Can you please check if slcan still works in your setup. I > don't have that hardware with me. I only was able to compile it successfully.
Sorry, I don't have access to the serial hardware currently. Best regards Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
