On Mon, 2014-06-23 at 11:02 -0700, Don Fry wrote: > On Mon, 2014-06-23 at 06:41 -0700, Joe Perches wrote: > > Remove the now unnecessary memset too. [] > > diff --git a/drivers/net/ethernet/amd/pcnet32.c > > b/drivers/net/ethernet/amd/pcnet32.c [] > > @@ -484,15 +484,13 @@ static void pcnet32_realloc_tx_ring(struct net_device > > *dev, > > > > pcnet32_purge_tx_ring(dev); > > > > - new_tx_ring = pci_alloc_consistent(lp->pci_dev, > > - sizeof(struct pcnet32_tx_head) * > > - (1 << size), > > - &new_ring_dma_addr); > > + new_tx_ring = pci_zalloc_consistent(lp->pci_dev, > > + sizeof(struct pcnet32_tx_head) * (1 > > << size), > > This causes the line length to be greater than 80 characters causing > checkpatch to complain.
Which doesn't bother me a whit. I prefer the multiply on the same line. If you prefer 80 columns that strongly though, let me know. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
