The Denali NAND driver reads only 5 bytes of ID, but some Hynix and Samsung
have size parameters in the 6th byte.  As a result, the page and oob size
for a Hynix H27UAG8T2B were calculated incorrectly and the driver failed to
load.

The solution is to read 8 bytes of ID, as expected by the nand framework.

Signed-off-by: Graham Moore <grmo...@altera.com>
--
V2: Increase size of id_bytes array to 8.
---
 drivers/mtd/nand/denali.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index 9f2012a..0b071a3 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -473,7 +473,7 @@ static void detect_partition_feature(struct 
denali_nand_info *denali)
 static uint16_t denali_nand_timing_set(struct denali_nand_info *denali)
 {
        uint16_t status = PASS;
-       uint32_t id_bytes[5], addr;
+       uint32_t id_bytes[8], addr;
        uint8_t i, maf_id, device_id;
 
        dev_dbg(denali->dev,
@@ -488,7 +488,7 @@ static uint16_t denali_nand_timing_set(struct 
denali_nand_info *denali)
        addr = (uint32_t)MODE_11 | BANK(denali->flash_bank);
        index_addr(denali, (uint32_t)addr | 0, 0x90);
        index_addr(denali, (uint32_t)addr | 1, 0);
-       for (i = 0; i < 5; i++)
+       for (i = 0; i < 8; i++)
                index_addr_read_data(denali, addr | 2, &id_bytes[i]);
        maf_id = id_bytes[0];
        device_id = id_bytes[1];
@@ -1276,7 +1276,7 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned 
int cmd, int col,
                addr = (uint32_t)MODE_11 | BANK(denali->flash_bank);
                index_addr(denali, (uint32_t)addr | 0, 0x90);
                index_addr(denali, (uint32_t)addr | 1, 0);
-               for (i = 0; i < 5; i++) {
+               for (i = 0; i < 8; i++) {
                        index_addr_read_data(denali,
                                                (uint32_t)addr | 2,
                                                &id);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to