On Wed, 2014-06-25 at 13:40 -0600, Shuah Khan wrote:
> The test fails in the middle when it is not run as root while
> accessing /proc/sys/kernel/msg_next_id. Changed it to check
> for root at the beginning of the test. Also added messages
> to indicate start and test pass status.
>
> Signed-off-by: Shuah Khan <shuah...@samsung.com>
> ---
> tools/testing/selftests/ipc/msgque.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ipc/msgque.c
> b/tools/testing/selftests/ipc/msgque.c
> index aa290c0..30c627a 100644
> --- a/tools/testing/selftests/ipc/msgque.c
> +++ b/tools/testing/selftests/ipc/msgque.c
> @@ -193,6 +193,12 @@ int main(int argc, char **argv)
> int msg, pid, err;
> struct msgque_data msgque;
>
> + if (getuid() != 0) {
> + fprintf(stderr, "Please run the test as root - Exiting.\n");
> + exit(1);
> + }
Please use err(3).
> + printf("Starting ipc tests:\n");
This is unnecessary and adds nothing to the program.
> msgque.key = ftok(argv[0], 822155650);
> if (msgque.key == -1) {
> printf("Can't make key\n");
> @@ -235,6 +241,7 @@ int main(int argc, char **argv)
> printf("Failed to test queue\n");
> goto err_out;
> }
> + printf("All ipc tests Passsed\n");
So is this.
> return 0;
>
> err_destroy:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
