On Thu, 26 Jun 2014 10:51:11 -0400 Rik van Riel <r...@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 06/19/2014 10:20 PM, Luiz Capitulino wrote: > > > @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct > > numa_meminfo *mi) end = max(mi->blk[i].end, end); } > > > > - if (start < end) - setup_node_data(nid, > > start, end); + if > > (start >= end) + continue; + + /* + > > * Don't confuse VM with a > > node that doesn't have the + * minimum amount of memory: + > > */ + > > if (end && (end - start) < NODE_MIN_SIZE) + continue; + + > > alloc_node_data(nid); } > > Minor nit. If we skip a too-small node, should we remember that we > did so, and add its memory to another node, assuming it is physically > contiguous memory? Interesting point. Honest question, please disregard if this doesn't make sense: but won't this affect automatic numa performance? Because the kernel won't know that that extra memory actually pertains to another node and hence that extra memory will have a difference distance of the node that's making use it of it. If my thinking is wrong or if even then you believe this is a good feature, I can work on it on a different patch, as this check is not being introduced by this patch. Although I also wonder how many numa machines have such small nodes... > Other than that... > > Acked-by: Rik van Riel <r...@redhat.com> Thanks! > > - -- > All rights reversed > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQEcBAEBAgAGBQJTrDNfAAoJEM553pKExN6DrNgH/j160OIey5moCEFMH51a1e3+ > D6iOIXxsVii5/wqabYuA1DCQ8Asgd/UK2BWdxxRZVZuTHXXn97iifq1IkIPEQxXc > pjz25/ZFSpa3fgZk8iyUzOQjLukFfkiaO1mSopO7IWwUZoEa9fJ7bOBvwcnFU4oQ > uZAV375RpxiPEXNh2qQZXX0kNrycZd8S81jUSuQv3OLPRI1EQo+txOg/u7ir0pOJ > z1fkBK0hiSHziAzB/nyjR/RgSb23vpMlUlPoGMhwCMp08aJkL147bHZvsCtlg/w4 > kBqq/zy9te4ecSicUsX/l16o0SJ9a1JtvFAlqz0iqlGcKQGCEw2P+y0ZyrhfvaE= > =NOgK > -----END PGP SIGNATURE----- > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
