On Sat, Jun 28, 2014 at 04:30:09AM +0200, Guillaume Morin wrote: > On 27 Jun 19:09, Greg Kroah-Hartman wrote: > > > v2: add missing Signed-off-by > > > > That doesn't go here. > > I guess I am struggling to get git send-email do what I want
Put that below the --- line. > > And what checkpatch error did you fix? And are you sure it needs to be > > fixed? > > That's what I changed: > > $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c > ERROR: Macros with complex values should be enclosed in parenthesis Then why didn't you say that :) > I assumed that if it was reported as an error, it needed to be fixed... Use your judgement, checkpatch is a tool, it isn't always correct. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
