On Mon, Jun 30, 2014 at 02:09:49PM -0700, Hugh Dickins wrote: > Do we really need an exported alias for __SetPageReferenced()? > Its callers better know what they're doing, in which case the page > would not be already marked referenced. Kill init_page_accessed(), > just __SetPageReferenced() inline. > > Signed-off-by: Hugh Dickins <[email protected]>
Ok, fair enough. The context it was written in was that callers should not need to know the internals of what mark_page_accessed does. Initially I thought there might be filesystem users that really should not know the internals but that is not necessary obviously. I still feel that init_page_accessed shows the intent more clearly and you're certainly right that the checking PageReferenced is redundant. I don't object to the patch but I don't think it's obviously better either other than it avoids the temptation of anyone using __SetPageReferenced incorrectly. Acked-by: Mel Gorman <[email protected]> -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
