On Wed, 25 Jun 2014, Chanwoo Choi wrote: > Add support for Samsung S2MPU02 PMIC device to the MFD sec-core driver. > The S2MPU02 device includes PMIC/RTC/Clock devices. > > Signed-off-by: Chanwoo Choi <[email protected]> > Reviewed-by: Krzysztof Kozlowski <[email protected]> > --- > drivers/mfd/sec-core.c | 46 ++++++--- > drivers/mfd/sec-irq.c | 110 +++++++++++++++++--- > include/linux/mfd/samsung/core.h | 1 + > include/linux/mfd/samsung/irq.h | 24 +++++ > include/linux/mfd/samsung/s2mpu02.h | 201 > ++++++++++++++++++++++++++++++++++++ > 5 files changed, 352 insertions(+), 30 deletions(-) > create mode 100644 include/linux/mfd/samsung/s2mpu02.h
I like what you've done, but really this patch should be split into 3 separate patches. One to consolidate the mfd_add_devices() calls, one to consolidate the regmap_add_irq_chip() calls and the final one to add support for the S2MPU02. When you submit them, you can apply my: Acked-by: Lee Jones <[email protected]> ... to each of them. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
