On Sun, Jun 8, 2014 at 2:12 PM, Alexandre Courbot <gnu...@gmail.com> wrote:
> On Thu, Jun 5, 2014 at 3:22 AM, abdoulaye berthe <berthe...@gmail.com> wrote:
>> This avoids handling gpiochip remove error in device
>> remove handler.
>>
(...)
>> Signed-off-by: abdoulaye berthe <berthe...@gmail.com>
>> - list_del(&chip->list);
>> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
>> + panic("gpio: removing gpiochip with gpios still
>> requested\n");
>
> Really, really I don't think we should panic here.
Nope dev_crit() is the right thing, with a big fat warning message.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
