Am Montag, 7. Juli 2014, 08:21:40 schrieb Mark Brown: > On Mon, Jul 07, 2014 at 09:08:41AM +0200, Heiko Stübner wrote: > > Am Montag, 7. Juli 2014, 09:42:52 schrieb addy ke: > > > > Your DT binding defined some additional compatible strings, please add > > > > those to the driver. > > > > citing Mark Rutland (one of the dt maintainers): > > > > -- > > > > That's why I said in addition to the common one. I'd only expect the > > > > driver to look for "rockchip,rk3066-spi", but a DTB could have: > > compatible = "rockchip,rk3188-spi", "rockchip,rk3066-spi"; > > > > Seeding the DTBs with the extra strings early makes it more likely that > > we can rely on them later. If we don't happen to need them they only > > clutter some DTBs. > > > > -- > > > > so it looks like the driver is doing the right thing right now > > The driver will work but it's better to list the strings that are > supported explicitly if only to document that there's nothing specific > Linux should be doing for them.
ok, makes sense :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
