2014-07-07 17:40 GMT+02:00 Linus Walleij <[email protected]>: > On Thu, Jun 26, 2014 at 1:31 PM, Rickard Strandqvist > <[email protected]> wrote: > >> Remove checking if a unsigned is less than zero >> >> This was found using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist <[email protected]> > (...) >> - if (WARN_ON(g->mux_bit < 0)) >> + if (WARN_ON(g->mux_bit != 0)) > > Is that correct? > > If the variable cannot be < 0 should the check not simply be > deleted, since this is all it checks for?
Hi Linus! Yes, it was a bit silly. Do not really know how that happened :-/ I guess I thought it was reasonable. But I should do as I have tried to do in all other cases, the smallest possible change. And let you check in code, if so, to capture what is missing. New patch on the way! Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
