On 07/10/2014 01:47 PM, Tom Gundersen wrote:
The name contains then xen handle, which is not guaranteed to be
stable between restarts, so label this NET_NAME_ENUM.

Signed-off-by: Tom Gundersen <t...@jklm.no>
Cc: Ian Campbell <ian.campb...@citrix.com>
Cc: Wei Liu <wei.l...@citrix.com>
Cc: xen-de...@lists.xenproject.org
---
  drivers/net/xen-netback/interface.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/xen-netback/interface.c 
b/drivers/net/xen-netback/interface.c
index 793275d..da906d1 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -418,8 +418,8 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t 
domid,
         * When the guest selects the desired number, it will be updated
         * via netif_set_real_num_*_queues().
         */
-       dev = alloc_netdev_mq(sizeof(struct xenvif), name, NET_NAME_UNKNOWN,
-                             ether_setup, xenvif_max_queues);
+       dev = alloc_netdev_mq(sizeof(struct xenvif), name, NET_NAME_ENUM, 
ether_setup,
+                             xenvif_max_queues);

What i am suggesting is irrelavent to this patch. But also consider this 
suggestion

In place sizeof(struct xenvif) --> sizeof(*vif) ???

        if (dev == NULL) {
                pr_warn("Could not allocate netdev for %s\n", name);
                return ERR_PTR(-ENOMEM);


--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to