On Fri, Jul 11, 2014 at 9:35 AM, <varkabhad...@gmail.com> wrote: > --- a/drivers/net/ethernet/amd/amd8111e.c > +++ b/drivers/net/ethernet/amd/amd8111e.c > @@ -197,23 +197,24 @@ static void amd8111e_set_ext_phy(struct net_device *dev) > advert = amd8111e_mdio_read(dev, lp->ext_phy_addr, MII_ADVERTISE); > tmp = advert & ~(ADVERTISE_ALL | ADVERTISE_100BASE4); > switch (lp->ext_phy_option) { > - default:
Behavior change from fall through and consider as auto-negotation... > - case SPEED_AUTONEG: /* advertise all values */ > - tmp |= (ADVERTISE_10HALF | ADVERTISE_10FULL | > - ADVERTISE_100HALF | ADVERTISE_100FULL); > - break; > - case SPEED10_HALF: > - tmp |= ADVERTISE_10HALF; > - break; > - case SPEED10_FULL: > - tmp |= ADVERTISE_10FULL; > - break; > - case SPEED100_HALF: > - tmp |= ADVERTISE_100HALF; > - break; > - case SPEED100_FULL: > - tmp |= ADVERTISE_100FULL; > - break; > + case SPEED_AUTONEG: /* advertise all values */ > + tmp |= (ADVERTISE_10HALF | ADVERTISE_10FULL | > + ADVERTISE_100HALF | ADVERTISE_100FULL); > + break; > + case SPEED10_HALF: > + tmp |= ADVERTISE_10HALF; > + break; > + case SPEED10_FULL: > + tmp |= ADVERTISE_10FULL; > + break; > + case SPEED100_HALF: > + tmp |= ADVERTISE_100HALF; > + break; > + case SPEED100_FULL: > + tmp |= ADVERTISE_100FULL; > + break; > + default: ... to do nothing. > + break; > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/