On Mon, Jul 14, 2014 at 9:09 AM, Peter Zijlstra <[email protected]> wrote: > On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote: >> Following patch added another way to get mmap name: >> 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name > > Please add to your .gitconfig: > > [core] > abbrev = 12 > > Also, you failed to CC the two people involved in that. > >> The vdso vma mapping already switch to this and we no longer >> get vdso name via arch_vma_name function. Adding this way to >> the perf mmap event name retrieval code. >> >> Caught this via perf test: >> >> $ sudo ./perf test -v 7 >> 7: Validate PERF_RECORD_* events & perf_sample fields : >> --- start --- >> >> SNIP >> >> PERF_RECORD_MMAP for [vdso] missing! >> test child finished with 255 >> ---- end ---- >> Validate PERF_RECORD_* events & perf_sample fields: FAILED! >> >> Cc: Arnaldo Carvalho de Melo <[email protected]> >> Cc: Corey Ashford <[email protected]> >> Cc: David Ahern <[email protected]> >> Cc: Frederic Weisbecker <[email protected]> >> Cc: Ingo Molnar <[email protected]> >> Cc: Namhyung Kim <[email protected]> >> Cc: Paul Mackerras <[email protected]> >> Cc: Peter Zijlstra <[email protected]> >> Signed-off-by: Jiri Olsa <[email protected]> >> --- >> kernel/events/core.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index 67e3b9c..4799676 100644 >> --- a/kernel/events/core.c >> +++ b/kernel/events/core.c >> @@ -5266,6 +5266,12 @@ static void perf_event_mmap_event(struct >> perf_mmap_event *mmap_event) >> >> goto got_name; >> } else { >> + if (vma->vm_ops && vma->vm_ops->name) { >> + name = (char *) vma->vm_ops->name(vma); >> + if (name) >> + goto cpy_name; >> + } >> +
Looks good to me. Sorry I missed that. --Andy >> name = (char *)arch_vma_name(vma); >> if (name) >> goto cpy_name; >> -- >> 1.8.3.1 >> -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
